Skip to content

Fixing Windows, using npx command#95

Closed
laopo001 wants to merge 2 commits intomodelcontextprotocol:mainfrom
laopo001:main
Closed

Fixing Windows, using npx command#95
laopo001 wants to merge 2 commits intomodelcontextprotocol:mainfrom
laopo001:main

Conversation

@laopo001
Copy link

@laopo001 laopo001 commented Dec 15, 2024

Motivation and Context

Fixing Windows, using npx command

How Has This Been Tested?

Yes, I have tested this modification on Windows.
cross-spawn is a very general library, resolve various issues that Node encounters when using spawn on Windows.

Breaking Changes

No

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

No

@laopo001 laopo001 changed the title Fixing Windows, using npx Fixing Windows, using npx command Dec 15, 2024
@anaisbetts
Copy link
Contributor

anaisbetts commented Dec 15, 2024

@laopo001 In Claude Desktop, we fix this via spawn-rx which does similar Windows-specific fixups but it might be nice to have this work for other MCP clients

jspahrsummers
jspahrsummers requested changes Dec 16, 2024
View reviewed changes
Copy link
Member

@jspahrsummers jspahrsummers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this seems useful!

Can you please share the sorts of tests that you ran to verify this works? Even better would be if it's possible to write some automated tests for this somehow. 🙏

@aiqlcom aiqlcom mentioned this pull request Dec 21, 2024
Closed
@dinhphieu
Copy link

dinhphieu commented Feb 16, 2025

Is this fixing this kind of issue? For some reason, on my Windows machine, StdioClientTransport can't seem to find npx anywhere in PATH

const githubTransport = new StdioClientTransport({
        command: "npx",
        args: ["-y", "@modelcontextprotocol/server-github"],
        env: {
            GITHUB_PERSONAL_ACCESS_TOKEN: process.env.GITHUB_PERSONAL_ACCESS_TOKEN!
        }
    });

Error: spawn npx ENOENT
    at Process.ChildProcess._handle.onexit (node:internal/child_process:286:19)
    at onErrorNT (node:internal/child_process:484:16)
    at processTicksAndRejections (node:internal/process/task_queues:90:21) {
  errno: -4058,
  code: 'ENOENT',
  syscall: 'spawn npx',
  path: 'npx',
  spawnargs: [ '-y', '@modelcontextprotocol/server-github' ]
}

@zhibisora zhibisora mentioned this pull request Mar 15, 2025
Merged
9 tasks
@zhibisora
Copy link

zhibisora commented Mar 24, 2025

I added a test for this pr in #198

Can someone go there to have a review?

@laopo001 laopo001 requested a review from jspahrsummers March 25, 2025 12:04
@laopo001
Copy link
Author

laopo001 commented Mar 25, 2025

What else do I need to do?

@jspahrsummers
Copy link
Member

jspahrsummers commented Mar 25, 2025

@laopo001 Please see my comment above.

@jspahrsummers
Copy link
Member

jspahrsummers commented Mar 26, 2025

Superseded by #198.

Pizzaface pushed a commit to RewstApp/mcp-inspector that referenced this pull request May 2, 2025
@jspahrsummers
Merge pull request modelcontextprotocol#95 from modelcontextprotocol/…
ace94c4 
…ashwin-ant-patch-1

link to MCP docs site in readme
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jspahrsummers jspahrsummers Awaiting requested review from jspahrsummers

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@laopo001 @anaisbetts @dinhphieu @zhibisora @jspahrsummers